This repository was archived by the owner on Sep 30, 2022. It is now read-only.
rsh: robustify the check for plm_rsh_agent default value #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't strcmp against the default value -- the default value may change over time. Instead, check to see if the MCA var source is not DEFAULT. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit open-mpi/ompi@71ec5cf)
|
Test PASSed. |
|
👍 |
|
@hppritcha and I talked -- approved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't strcmp against the default value -- the default value may change over time. Instead, check to see if the MCA var source is not DEFAULT.
Signed-off-by: Jeff Squyres [email protected]
(cherry picked from commit open-mpi/ompi@71ec5cf)
Reviewed by @rhc54 in open-mpi/ompi#1972